Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and release a new version with butterchurn #13

Open
durasj opened this issue Jan 28, 2020 · 4 comments
Open

Bump dependencies and release a new version with butterchurn #13

durasj opened this issue Jan 28, 2020 · 4 comments

Comments

@durasj
Copy link
Owner

durasj commented Jan 28, 2020

There is currently WIP branch https://github.com/durasj/webamp-desktop/tree/webamp-real-dep using the webamp as a dependency instead of the custom bundle we currently have.

It would be nice to finalize it, bump other packages as well and release that as a new version together with media keys and other stuff added in the meantime.

@durasj
Copy link
Owner Author

durasj commented Jan 28, 2020

There is currently one blocker. We can't include the butterchurn because it's currently doing unsafe eval on presets at runtime. We've talked about this with @captbaritone and this should be eventually solved by their upcoming WASM compiler. In the meantime, it's possible we'll be able to create a workaround that will allow us to merge this sooner and will help with the effort around compiler.

@daemonspudguy
Copy link

@durasj it's been almost 3 years since this issue was made and almost 4 since the project has had any updates. Has something happened?

@captbaritone
Copy link

@durasj can reply for himself if he wants, but I think this project was intended more as a proof of concept novelty than a real media application for users. I think that explains the lack of continued investment after the initial proof of concept phase was completed.

That said, I'd be curious to hear how you are using Webamp desktop and what motivated you to follow up on this issue. Are you using it regularly, or hoping to be able to?

@captbaritone
Copy link

As far as an update on my end, we do how have the Wasm compiler for Milkdrop presets, so it would be feasible to use a version of the library I believe.

https://jordaneldredge.com/blog/speeding-up-winamps-music-visualizer-with-webassembly/

durasj added a commit that referenced this issue Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants