Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs width resizing glitch #3695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rkrenecky
Copy link

@rkrenecky rkrenecky commented Jan 4, 2025

Fixes #3694

Description:

  • Removes the rounding logic from the tab width calculation to fix the UI glitch that occurs during "traffic lights" (minimize/close/fullscreen buttons) visibility transitions in fullscreen mode.
  • The rounding had no measurable performance benefit, and its removal ensures that tab widths resize smoothly and consistently during traffic lights visibility changes.

Steps to test this PR:

  1. Open enough tabs to fill the screen width in fullscreen mode.
  2. Move the cursor to the top of the screen to make the traffic lights appear.
  3. Verify that tabs shift positions smoothly to make space for the traffic lights.

Evidence:

tabs-glitch-fixed.mov

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jan 12, 2025
@samsymons samsymons self-requested a review January 14, 2025 21:30
@samsymons samsymons removed the stale label Jan 14, 2025
Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs width resizing glitch during "traffic lights" visibility changes
2 participants