Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parts from the original algorithm #7

Open
AxFaure opened this issue Jun 20, 2021 · 0 comments
Open

Missing parts from the original algorithm #7

AxFaure opened this issue Jun 20, 2021 · 0 comments

Comments

@AxFaure
Copy link

AxFaure commented Jun 20, 2021

Hi !

I noticed that several optimization that are present in the original implementations of the diff algorithm in this repo were not implemented in this crate. For instance dissimilar has no:

  • line_mode
  • half_diff
  • timeout
    (There may be other missing features that I did not notice)

Since there is no mention of it in the Readme, I was wondering why you did not include them.
Are these features you didn't have time to implement / don't think are useful or is there any issue preventing their implementation?
And as a result, do you think we should consider adding them to the crate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant