Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Word by Word to .NETCore 3 #38

Open
dsarlo opened this issue Jan 31, 2019 · 0 comments
Open

Port Word by Word to .NETCore 3 #38

dsarlo opened this issue Jan 31, 2019 · 0 comments
Labels

Comments

@dsarlo
Copy link
Owner

dsarlo commented Jan 31, 2019

Preliminary research/testing:

Should just be as easy as changing the csproj to the new .NETCore version.

After attempting to convert to .NETCore v3.0.0-preview2, I have discovered that...

MahApps.Metro.IconPacks, MVVMLightLibs, and Microsoft.Xaml.Behaviors.Wpf are not fully compatible yet, while all other nuget packages and API's are ready for the jump.

As for the csproj file, necessary for porting to .NETCore 3, with the current version, it looks like this:

<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <UseWPF>true</UseWPF>
    <AssemblyName>WordByWord</AssemblyName>
    <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
    <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
    <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
    <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
    <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
    <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
  </PropertyGroup>
  <ItemGroup>
    <None Remove="Resources\Word-by-Word-Google-Service-Account.json" />
  </ItemGroup>
  <ItemGroup>
    <EmbeddedResource Include="Resources\Word-by-Word-Google-Service-Account.json" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="CommonServiceLocator" Version="2.0.4" />
    <PackageReference Include="Google.Cloud.Vision.V1" Version="1.3.0-beta04" />
    <PackageReference Include="MahApps.Metro" Version="2.0.0-alpha0212" />
    <PackageReference Include="MahApps.Metro.IconPacks" Version="3.0.0-alpha0103" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="3.0.0-preview.19074.2" />
    <PackageReference Include="MvvmLight" Version="5.4.1.1" />
    <PackageReference Include="MvvmLightLibs" Version="5.4.1.1" />
    <PackageReference Include="Newtonsoft.Json" Version="12.0.1" />
  </ItemGroup> 
</Project>

Follow this blog for .NETCore csproj changes: http://brianlagunas.com/getting-started-net-core-3-create-wpf-application/

Must update to the new theme manager for MahApps and do the following:
image

@dsarlo dsarlo added this to the Sprint 2 milestone Jan 31, 2019
@dsarlo dsarlo self-assigned this Jan 31, 2019
@dsarlo dsarlo removed this from the Sprint 2 milestone Feb 1, 2019
@dsarlo dsarlo removed their assignment Feb 1, 2019
dcgoings added a commit that referenced this issue Feb 18, 2019
Default values set to 120 WPM, 500ms reader delay.
CalculateDelay function implemented for single word and groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant