fix some scan-build warnings

ds4dm · May 20, 2022 · 7452b65 · 7452b65
1 parent b201432
commit 7452b65
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/src/abstractgraph.cc b/src/abstractgraph.cc
@@ -1643,7 +1643,7 @@ AbstractGraph::search(const bool canonical,
         /*
          * Compute backjumping level
          */
-        unsigned int backjumping_level = current_level+1-1;
+        unsigned int backjumping_level;
         if(!first_path_orbits.is_minimal_representative(search_stack[gca_level_with_first].split_element))
           {
             backjumping_level = gca_level_with_first;

diff --git a/src/bliss.cc b/src/bliss.cc
@@ -238,7 +238,10 @@ main(const int argc, const char** argv)
     fclose(infile);
 
   if(!g)
+  {
     _fatal("Failed to read the graph, aborting");
+    exit(1); /* this is here because scan-build does not recognize _fatal exits. */
+  }
 
 #ifndef _WIN32
   if(verbose_level >= 2)

diff --git a/src/digraph.cc b/src/digraph.cc
@@ -402,7 +402,10 @@ Digraph::read_dimacs(FILE* const fp, FILE* const errstr)
   unsigned int line_num = 1;
 
   const bool verbose = false;
-  FILE* const verbstr = stdout;
+  FILE* verbstr;
+  if(verbose)
+      verbstr = stdout;
+
 
   /* Read comments and the problem definition line */
   while(1)

diff --git a/src/graph.cc b/src/graph.cc
@@ -171,7 +171,9 @@ Graph::read_dimacs(FILE* const fp, FILE* const errstr)
   int c;
 
   const bool verbose = false;
-  FILE* const verbstr = stdout;
+  FILE* verbstr;
+  if(verbose)
+      verbstr = stdout;
 
   /* Read comments and the problem definition line */
   while(1)