Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSPath md5 hash property could potentially be supported #482

Open
fafnirZ opened this issue Oct 30, 2024 · 1 comment · Fixed by #483
Open

GSPath md5 hash property could potentially be supported #482

fafnirZ opened this issue Oct 30, 2024 · 1 comment · Fixed by #483

Comments

@fafnirZ
Copy link

fafnirZ commented Oct 30, 2024

In the supported methods and properties table in the README, it shows that the md5 property is only supported for AzureBlobPath, but isnt supported for GSPath.

however there exists a property returned by bucket.get_blob: Blob.md5_hash
https://cloud.google.com/python/docs/reference/storage/latest/google.cloud.storage.blob.Blob#google_cloud_storage_blob_Blob_md5_hash

so if I understand correctly it should be as simple as updating a line in this dictionary to reflect that,

(and adding a property inside GSPath too)

Happy to submit a PR for it which addresses this and updates docs / tests if this functionality is wanted!!

@pjbull
Copy link
Member

pjbull commented Oct 30, 2024

Great, we would accept a PR. You can find contribution guidelines here: https://cloudpathlib.drivendata.org/stable/contributing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants