Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth adding Gemfile.lock to default git export? #25

Open
zealot128 opened this issue Nov 2, 2015 · 3 comments
Open

Worth adding Gemfile.lock to default git export? #25

zealot128 opened this issue Nov 2, 2015 · 3 comments

Comments

@zealot128
Copy link
Contributor

I've noticed that Gemfile.lock is missing from default git archive command https://github.com/dresden-weekly/ansible-rails/blob/develop/rails/create-release/defaults/main.yml#L19

With a personal app, I just had problems with divergent gem versions production/development. Of course, I can manually add the file to the custom list.

But I think, for most apps it is desired to keep the Gemfile.lock and do not upgrade automatically (AFAIK most apps versions are more relaxed).
I know, with Redmine/ multiplatform deployment, you overwrite Gemfile.lock, but I sense, Gemfile.lock would be a good default.

That, or choosing a different strategy than git archiving (like just copying over the archive).

What do you think @arBmind @tnt ?

@arBmind
Copy link
Member

arBmind commented Nov 10, 2015

I know it's hot discussion.
For me Gemfile.lock never worked as intended. Windows will always require different gems.
It would be best to use a Heroku like approach:

  • If the Gemfile.lock is present in the sources it should be used.
  • If no Gemfile.lock is present, it should be generated for each deployment.

Bonus would be to scan for mingw/windows platforms and ignore the Gemfile.lock in these cases.

@zealot128
Copy link
Contributor Author

Yes, that approach sounds perfect.
I guess, people who develop & deploy on different platforms would'nt check in the Gemfile.lock, anyway.
But I think, the majority of developers would (or better: should) develop & deploy on similiar platforms.

The "help wanted" label means, I would do it? :)

@arBmind
Copy link
Member

arBmind commented Nov 28, 2015

Would be really appreciated if you can help one more time. I won't have time before April next year to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants