Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ugly new interface with dark browser theme #84

Open
n-think opened this issue Sep 13, 2016 · 10 comments
Open

ugly new interface with dark browser theme #84

n-think opened this issue Sep 13, 2016 · 10 comments
Assignees

Comments

@n-think
Copy link

n-think commented Sep 13, 2016

Your DownThemAll! and Browser Version and Language and Operating System

all 3.0+ versions on firefox with dark theme

Expected Behavior

like in 2.0

Actual Behavior

pekjvet

its ugly

@nmaier
Copy link
Member

nmaier commented Sep 13, 2016

Can you tell me please what theme on what OS?

@n-think
Copy link
Author

n-think commented Sep 13, 2016

Hi,
Im using firefox on win 10 with
https://addons.mozilla.org/en-US/firefox/addon/ft-deepdark/ theme, some
users reported same problem with screenshots on
https://addons.mozilla.org/en-US/firefox/addon/downthemall/ in reviews

here is how it looked in 2.0

@nmaier
Copy link
Member

nmaier commented Sep 13, 2016

xqyzwbx

@nmaier
Copy link
Member

nmaier commented Sep 13, 2016

The best would be if the author would support DownThemAll!, i.e theme it in an appropriate way in their theme.
But I will look into improving this nonetheless

@nmaier
Copy link
Member

nmaier commented Sep 17, 2016

@n-think
Copy link
Author

n-think commented Sep 19, 2016

thx looks good now, can u also make some icons on the left bit brighter (more vivid) with dark themes?
http://imgur.com/a/0aSeA

@NR2014
Copy link

NR2014 commented Sep 19, 2016

Yes i too use Ft-dark theme and its completely unusable UI/toolbar for DTA.
Please correct for dark theme users.

@nmaier
Copy link
Member

nmaier commented Sep 19, 2016

I cannot even know what is a "dark" theme and what is a "bright" theme. Therefore I cannot "correct" anything for dark themes specifically, but have to find a compromise that will work good on default themes and OK-ish on dark themes.

And yes, I will prefer working good on default themes any time over looking better on dark themes, because
a) default themes have far more users
b) non-default themes are in the unique position that the THEME author can provide DTA styles that will make it good, but we cannot provide customize styles for any and every theme out there (if alone for scale, and for tech limitations)

Having said that, I will take/make fixes that work with default themes and still improve non-default themes

@NR2014
Copy link

NR2014 commented Sep 20, 2016

I agree that its not wise to spend time for minor user group. But please do remember we use dark theme mainly for night time browsing , as the simple themes dont accomplish much. Atleast can you add a option so that those who want can switch DTA to full dark mode ? Even RES has this feature and nowadays almost all apps(android for eg) and many softwares are implementing the dark mode.

Thanks in advance.

@nmaier
Copy link
Member

nmaier commented Sep 20, 2016

Atleast can you add a option so that those who want can switch DTA to full dark mode ?

That's not an "at least", that's a full blown feature requiring a lot of coding, testing, maintenance.
There is no Firefox API to just switch themes on the fly, so it would require tons of work-arounds. Also, of course, there is no Firefox Desktop "Night mode" or similar, or a reliable way to detect if a theme is dark or not.

RES

No idea what you're referring to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants