Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Filter based on detected type to exclude "share" links #54

Open
ssokolow opened this issue Sep 4, 2016 · 0 comments
Open

Comments

@ssokolow
Copy link

ssokolow commented Sep 4, 2016

Your DownThemAll! and Browser Version and Operating System

DownThemAll: 3.0.5
Firefox: 49.0a2 (2016-08-01)
OS: Lubuntu Linux 14.04

Expected Behavior

DownThemAll should have a way to filter based on whatever source it uses to assign icons to detected links. (This successfully identifies images without catching Pinterest share links)

Actual Behavior

DownThemAll seems to only allow filtering by raw URL matching, which results in false positives for Pinterest share links when you filter for images.

Steps To Reproduce

  1. Go to any Tumblr blog which incorporates Pinterest buttons
  2. Open DownThemAll's file picker to the links tab
  3. Look at how actual images in the list get image icons while Pinterest links do not
  4. Try toggling the images filter and look at how both images and Pinterest links get selected/deselected.

Additional info such as log extracts

Because I generally notice this on NSFW blogs, I'd rather not give a log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants