Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP-files get corrupted when downloaded through DownThemAll! #141

Open
DoesntMatterWhat opened this issue Nov 1, 2016 · 3 comments
Open

Comments

@DoesntMatterWhat
Copy link

DoesntMatterWhat commented Nov 1, 2016

Your DownThemAll! and Browser Version and Language and Operating System

  • DownThemAll! v3.0.8
  • Firefox v49.0.2

Expected Behavior

An uncorrupted ZIP-file after download.

Actual Behavior

A corrupted ZIP-file with CRC-errors.

Steps To Reproduce

  1. Download a ZIP-file, for instance this one:
    http://www.archive.org/download/poorboys_1210_librivox/poorboys_1210_librivox_64kb_mp3.zip
  2. Try to unpack the ZIP-file with WinRAR. CRC-errors will occur.
  3. Open the ZIP-file with WinRAR and click on "Test" to verify the ZIP-file. CRC-errors are shown.

Additional info such as log extracts

None

@DoesntMatterWhat DoesntMatterWhat changed the title ZIP-files get corrupted when downloaded through DownThemAll. ZIP-files get corrupted when downloaded through DownThemAll! Nov 1, 2016
@pumrum
Copy link

pumrum commented Nov 3, 2016

I can confirm the same behavior with that one download link on the following system:
DTA 3.0.8 | Firefox 49.0.2 | English (US) | Ubuntu MATE 16.04

MD5 hashes of the files downloaded direct, and also using DTA:
9d1659d4f367b65bb8dd4ba923e33c1f poorboys_1210_librivox.zip_direct
9b25f745224389a678e2403a70048c92 poorboys_1210_librivox.zip_dta

I can, however, confirm that with the same system, I download 1000s of ZIP files on a very regular basis from both public and private sites. One example:

https://notepad-plus-plus.org/repository/7.x/7.2/npp.7.2.bin.x64.zip
8c2639c2f25d76cd54ebc2f70d7cd5d1 npp.7.2.bin.x64.zip_direct
8c2639c2f25d76cd54ebc2f70d7cd5d1 npp.7.2.bin.x64.zip_dta

I also download very regularly from managed download sites such as Oracle Support which uses identity tokens and other such time-limiters, and the checksum hashes always match.

I have a feeling (though I have no way to back this up) that it's either something specific to archive.org or the nature of the ZIP file(s) you're downloading?

@BooSN
Copy link

BooSN commented Nov 3, 2016

Its not limited to archive.org. I had some broken archives since i use DTA 3 but i was thinking my HDD is dying.
When byte-comparing both files there are more than 120 differences. Strange.
It works if segments are limited to 1. Its slower but still better than no DTA at all.
Lets hope Nils finds some time to fix this.

@jboadas
Copy link

jboadas commented Jan 11, 2017

I have this problem too using Windows 10 64, Firefox 50.1.0 and DownThemAll 3.0.8. Any clues to avoid this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants