Remove the custom sampling loop (SequenceGenerator) #1449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1422
The objective of this PR is to remove the custom sampling loop (and related entities) that are not used anymore or can be replaced with other elements that are already in outlines. We want to make this commit such that it's convenient to revert the change proposed in the future.
What is modified:
SequenceGenerator
(it was already not used anymore)SequenceGeneratorAdapter
generate.<something>
functions to useGenerator
instead ofSequenceGeneratorAdapter
generate
testssamplers
module and associated tests/documentation (not needed anymore as it was used for providing a sampler for the custom loop)What is not modified:
VLLM
andExLlamaV2Model
models that have not been refactored yet and thus still expect to interact withSequenceGeneratorAdapter