Prevent native obj files from being uploaded to build artifact #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jander-msft
added
servicing-patch
kkeirstead
approved these changes
Feb 7, 2025
|
/backport to release/8.0 |
|
/backport to release/8.x |
|
Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/13190695845 |
|
/backport to release/9.x |
|
Started backporting to release/8.x: https://github.com/dotnet/dotnet-monitor/actions/runs/13190697192 |
|
Started backporting to release/9.x: https://github.com/dotnet/dotnet-monitor/actions/runs/13190698852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CMake places a lot of binaries under the
obj/win-x64.Releaseoutput folder during build. Some of the scanning tools flag some of these binaries as not being compliant (e.g. needing to add EnableControlFlowGuard to CompilerIdC.exe). The repository doesn't ship those binaries. To avoid being flagged, delete theobj/win-x64.Releasefolder before uploading it as a build artifact; it is not necessary for downstream consumers of the build.Validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2635369
Release Notes Entry