Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase token expiration and retry until compatible token #7239

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

jander-msft
Copy link
Member

@jander-msft jander-msft commented Aug 30, 2024

Summary
  • Increase the token expiration for Helix runs. The test job allows Helix up to 2 hours since it can take some time to wait in the Helix queues before tests are run. Don't want the token to expire before the tests get a chance to run.
  • Update the get-delegation-sas yaml to retry getting a token if it contains a forward slash. Tokens with forward slashes seem to trip up Helix and cause it to not download the correlation payload. Similar workarounds have been employed elsewhere: https://github.com/dotnet/aspnetcore/blob/release/6.0/eng/common/templates-official/steps/get-delegation-sas.yml#L34

Validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2528027&view=results

Release Notes Entry

@jander-msft jander-msft merged commit d4679c2 into dotnet:release/9.x Aug 31, 2024
27 checks passed
@jander-msft jander-msft deleted the token-updates branch August 31, 2024 01:58
@jander-msft
Copy link
Member Author

/backport to main

@jander-msft
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

Started backporting to main: https://github.com/dotnet/dotnet-monitor/actions/runs/10641479158

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/10641479839

@jander-msft
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/11186596050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants