-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizing textures to 2k is broken for a particular model #562
Comments
Hm thanks! I think my resizing dependency (https://github.com/donmccurdy/ndarray-lanczos) is having trouble with some input/output ratios, like the 5464x3070 input here. I'm using that package because it works both on the web and in node.js, but there are much better (faster, more stable) alternatives for node.js, like sharp or squoosh/lib. If speed and memory footprint are an important concerns, you might want to try swapping out a couple lines here for a different resizing library: glTF-Transform/packages/functions/src/texture-resize.ts Lines 79 to 88 in a17b296
|
I've been hoping |
Describe the bug
While reducing texture sizes, I noted that a particular model produces wrong results in specific texture sizes; 2k breaks and 1k works.
To Reproduce
Steps to reproduce the behavior:
gltf-transform resize --width 2048 --height 2048 066.glb 066.2048.glb
gltf-transform resize --width 1024 --height 1024 066.glb 066.1024.glb
Expected behavior
Same appearance between 1024 and 2048px, and consistent with the input.
Versions:
The text was updated successfully, but these errors were encountered: