Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ds_list() doesn't include display type or data provider #4

Open
smach opened this issue Mar 24, 2021 · 3 comments
Open

New ds_list() doesn't include display type or data provider #4

smach opened this issue Mar 24, 2021 · 3 comments
Assignees

Comments

@smach
Copy link

smach commented Mar 24, 2021

Hi, thanks for the new package! The old DomoR::list_ds() included information about the data set type and source, including columns for displayType and dataProviderType. That's useful information! The new domor ds_list does not seem to have that. Is there any chance of getting that information into the new version?

@smach smach changed the title New ds doesn't include display type or data provider New ds_list() doesn't include display type or data provider Mar 24, 2021
@jimmyg3g
Copy link

Interesting, ds_list() calls the "/v1/datasets" API endpoint as documented at https://developer.domo.com/docs/dataset-api-reference/dataset#List%20DataSets. DomoR::list_ds() calls "/api/data/v3/datasources", which is not documented, but it is the endpoint the the web UI calls when searching for datasets.

@jeremydmorris jeremydmorris self-assigned this Mar 25, 2021
@jeremydmorris
Copy link
Contributor

As mentioned, we have switched to the public APIs and, therefore, some of the information will be different. Personally, I think the data source type should be returned here as it is with the other endpoint. My suggestion is to submit a ticket with Domo support with these details and have them reach out to me. That way I can provide some context and participate in the process of getting the API updated.

@smach
Copy link
Author

smach commented Mar 30, 2021

I'm just going to use the old package to get the information until that doesn't work anymore then, thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants