You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Very last thing (promise!) - when checking out the results of the new functionality in #46, I noticed that "inline" comments are not captured by todor, e.g. if I have the following text in an Rmarkdown doc on line 147:
Participants were followed up, and were censored at the earliest of date of diagnosis, death, date of transfer out of the study cohort or end of follow-up ( <!-- TODO Get date here --> )
This does not appear as a marker when running todor() (no "Line 147"):
Is this known behaviour?
The text was updated successfully, but these errors were encountered:
Thanks for reporting that @mcguinlu . Indeed, that's again my lack of general thinking. You can see that the pattern detects both hash and HTML comment tags but only at the beginning of the line: https://github.com/dokato/todor/blob/master/R/patterns.R#L21 , in case of nothing is detected we proceed with inline_pattern that seems to detect only hashes now... This needs to be fixed.
A completely different story is multiline comments as requested in #43 ; so far TODOr iterates line by line over code to detect appropriate tags. I need to think more how to neatly account for that 🤔 Shouldn't be quantum physics though...
Hi @dokato,
Very last thing (promise!) - when checking out the results of the new functionality in #46, I noticed that "inline" comments are not captured by
todor
, e.g. if I have the following text in an Rmarkdown doc on line 147:This does not appear as a marker when running
todor()
(no "Line 147"):Is this known behaviour?
The text was updated successfully, but these errors were encountered: