Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard focus is moving to the hidden elements present inside the collapsed hamburger menu. #2306

Closed
msftedad opened this issue Nov 28, 2023 · 2 comments

Comments

@msftedad
Copy link

Bug Report

Steps to reproduce

  1. Open the PWA Builder URL-https://docs.pwabuilder.com/#/ in Edge browser.
  2. PWA Builder page will appear.
  3. Collapse the hamburger menu.
  4. Now navigate from the top of the page.
  5. Observe the issue.

Current behaviour

Keyboard focus is moving to the hidden controls which is present inside the collapse hamburger menu.

Attachments:

Keyboard.focus.is.moving.to.the.hidden.elements.present.inside.the.collapsed.hamburger.menu.mp4
Keyboard.focus.is.moving.to.the.hidden.elements.present.inside.the.collapsed.hamburger.menu1.mp4

Expected behaviour

Keyboard focus should not move inside the hamburger menu when it is in collapsed state.

Other relevant information

  • Docsify version: 4.4.4
  • [ X] Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): NA

Please create a reproducible sandbox

(https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/307qqv236)](https://docs.pwabuilder.com/#/)

Mention the docsify version in which this bug was not present (if any)

NA

@paulhibbitts
Copy link
Collaborator

paulhibbitts commented Nov 29, 2023

Thanks very much @msftedad for reporting this issue. I think the following PR (still to be released) addresses this issue #2265

Could you please try the "Visit Preview" link in the PR and confirm? Thank you!

@jhildenbiddle
Copy link
Member

Fixed via #2253 and #2265.

These updates will be available in the next release. Until then, you can verify the changes by visiting the develop branch preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants