Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - hidden anchors are still tabbable #2225

Closed
1 task done
kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2265
Closed
1 task done

Accessibility - hidden anchors are still tabbable #2225

kburk1997 opened this issue Sep 12, 2023 · 1 comment · Fixed by #2265
Assignees

Comments

@kburk1997
Copy link

Bug Report

Steps to reproduce

  1. Go to develop preview
  2. Press Tab key to move to next focusable element on the page
  3. Repeat step 2 until "Edit document" link is focused

Current behaviour

Sidebar items remain in the tab order regardless of whether the menu is open or closed.
Screen recording with keystrokes:

Screen.Recording.2023-09-12.at.11.11.40.AM.mov

Expected behaviour

Hidden sidebar items are not tabbable when closed.
Sidebar items are tabbable when the sidebar is open.

Other relevant information

  • Docsify version: latest
  • Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue): n/s

@jhildenbiddle
Copy link
Member

Thanks for creating the issue, @kburk1997!

I've created a draft PR here: #2265. In that PR you will find a preview link which will allow you to review the changes:

CleanShot 2023-10-17 at 08 59 27@2x

Before I mark this PR as ready for review by the maintainers, I would love to get your thoughts and/or feedback.

Thanks!

@jhildenbiddle jhildenbiddle linked a pull request Nov 16, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants