Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] sdk support detecting request's cancellation #129

Open
tangjz opened this issue Mar 25, 2021 · 0 comments
Open

[Feature Request] sdk support detecting request's cancellation #129

tangjz opened this issue Mar 25, 2021 · 0 comments

Comments

@tangjz
Copy link

tangjz commented Mar 25, 2021

Due to this pull request moby/moby#35441, now requests to volume plugin may be canceled by client, but sdk here doesn't provide a context for that, which is very risky.

For example, if the timeout duration set by a plugin (e.g. 300s) is longer than that of the daemon (i.e. 60s or 120s depending on request type), and in fact a mount request would cost ~200s, then the plugin may create a mount point successfully while the daemon will regard it as timeout. In that case, an unexpected mount point will be created and become out of control.

Related code:

My opinion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant