You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to this pull request moby/moby#35441, now requests to volume plugin may be canceled by client, but sdk here doesn't provide a context for that, which is very risky.
For example, if the timeout duration set by a plugin (e.g. 300s) is longer than that of the daemon (i.e. 60s or 120s depending on request type), and in fact a mount request would cost ~200s, then the plugin may create a mount point successfully while the daemon will regard it as timeout. In that case, an unexpected mount point will be created and become out of control.
Due to this pull request moby/moby#35441, now requests to volume plugin may be canceled by client, but sdk here doesn't provide a context for that, which is very risky.
For example, if the
timeout
duration set by a plugin (e.g. 300s) is longer than that of the daemon (i.e. 60s or 120s depending on request type), and in fact a mount request would cost ~200s, then the plugin may create a mount point successfully while the daemon will regard it as timeout. In that case, an unexpected mount point will be created and become out of control.Related code:
moby/moby@b15f8d2#diff-c67d588225dded3cafa5ef6cc304c7ad8cd5e2fcda17eb7842d1f8baf3f36934
https://github.com/docker/go-plugins-helpers/blob/master/sdk/encoder.go#L14-L19
My opinion:
plugin enable
--timeout
option moby/moby#37426The text was updated successfully, but these errors were encountered: