artifact upload causes issue with download-action

[devinrsmith]

Contributing guidelines

• I've read the contributing guidelines and wholeheartedly agree

I've found a bug, and:

• The documentation does not mention anything about my problem
• There are no open or closed issues that are related to my problem

Description

I was holding off on updating from v4 to v5 for a while, but finally figured out the issue.

The dockerbuild asset being uploaded (by default) for the bake action v5+ seems to interact poorly with https://github.com/actions/download-artifact (v4 at the time of this issue); in my case, causing the job to fail with an error that looks like

Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries

Note: I'm able to manually download the artifact just fine.

I'm not specifically trying to download the bake action artifact; it just gets picked up by default from the download-artifact config:

If unspecified, all artifacts for the run are downloaded.

Here is an abbreviated download-artifact log:

2025-01-06T21:40:14.5781926Z ##[group]Run actions/download-artifact@v4
2025-01-06T21:40:14.5783077Z with:
2025-01-06T21:40:14.5783818Z   path: download-artifacts
2025-01-06T21:40:14.5784753Z   merge-multiple: false
2025-01-06T21:40:14.5785662Z   repository: jpy-consortium/jpy
2025-01-06T21:40:14.5786639Z   run-id: 12640584882
2025-01-06T21:40:14.5787445Z ##[endgroup]
2025-01-06T21:40:14.8914903Z Found 33 artifact(s)
2025-01-06T21:40:14.8916299Z No input name or pattern filtered specified, downloading all artifacts
2025-01-06T21:40:14.8917477Z An extra directory with the artifact name will be created for each download
2025-01-06T21:40:14.8918504Z Preparing to download the following artifacts:
2025-01-06T21:40:14.8919566Z - jpy-consortium~jpy~CN2MCZ+7.dockerbuild (ID: 2392634734, Size: 1206080)
2025-01-06T21:40:14.8920682Z - bdist-wheel-linux-arm64 (ID: 2392634341, Size: 2451499)
2025-01-06T21:40:14.8921588Z - build-3.13t-ubuntu-20.04-aarch64 (ID: 2392588682, Size: 346583)
...
2025-01-06T21:40:14.8951132Z - build-3.10-ubuntu-20.04-amd64 (ID: 2392571891, Size: 347504)
2025-01-06T21:40:14.8952131Z - jars (ID: 2392571697, Size: 151576)
2025-01-06T21:40:14.8953000Z - sdist (ID: 2392571048, Size: 184418)
2025-01-06T21:40:15.0188651Z Redirecting to blob download url: https://productionresultssa15.blob.core.windows.net/actions-results/558cfb3f-e755-4e6d-9825-b4257f7f48e3/workflow-job-run-23f659b9-ea4c-5943-f50c-c004c103afa8/artifacts/3c96893479e9a206b7239464ac2f7b1cc6979d7e170e980f51f818a036d90730.zip
2025-01-06T21:40:15.0191125Z Starting download of artifact to: /home/runner/work/jpy/jpy/download-artifacts/jpy-consortium~jpy~CN2MCZ+7.dockerbuild
2025-01-06T21:40:15.0356901Z Redirecting to blob download url: https://productionresultssa15.blob.core.windows.net/actions-results/558cfb3f-e755-4e6d-9825-b4257f7f48e3/workflow-job-run-5a789381-7bfb-5e05-8a57-388692c58e9c/artifacts/5983eae37f85bb9fbccc11e2156e7322441e4998c74e6cdb5128cea03d0df157.zip
...
2025-01-06T21:40:15.1715438Z Artifact download completed successfully.
...
2025-01-06T21:40:25.1214258Z Artifact download completed successfully.
2025-01-06T21:40:40.3053143Z ##[error]Unable to download artifact(s): Unable to download and extract artifact: Artifact download failed after 5 retries.

I think the version between actions/download-artifact and actions/upload-artifact are meant to be kept in-sync; I suspect the upload logic in https://github.com/docker/actions-toolkit may be incompatible with actions/download-artifact (v4)?

Or maybe, the ~ or + characters in the filename are causing issues?

In the meantime, I'm able to workaround this by disabling the bake action artifact upload:

        uses: docker/[email protected]
        env:
          DOCKER_BUILD_RECORD_UPLOAD: false

Expected behaviour

docker/bake-action should not cause downstream issues with actions/download-artifact.

Actual behaviour

docker/bake-action is causing actions/download-artifact to fail

Repository URL

https://github.com/jpy-consortium/jpy

Workflow run URL

https://github.com/jpy-consortium/jpy/actions/runs/12640584882

YAML workflow

https://github.com/jpy-consortium/jpy/blob/v1.1.0/.github/workflows/build.yml

Workflow logs

Can provide if needed.

BuildKit logs

Additional info

No response

[crazy-max]

Yes this is a known issue, see actions/download-artifact#367 (comment)

[devinrsmith]

My GH issue search was not good enough. Thanks.