Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow publish_release #39

Closed
3 tasks
ClaasRostock opened this issue Nov 14, 2024 · 0 comments · Fixed by #40
Closed
3 tasks

Update GitHub workflow publish_release #39

ClaasRostock opened this issue Nov 14, 2024 · 0 comments · Fixed by #40
Assignees

Comments

@ClaasRostock
Copy link
Contributor

  • .github/workflows/publish_release.yml : Run publishing job from main (non-reusable) workflow.
  • Remove the two reusable workflows _publish_package.yml and _publish_package_test.yml.
  • Update the trusted publishing settings on pypi to 'publish_release.yml' as the workflow name running the publishing step.

Background for this change is a limitation recently introduced on pypi, which does not allow anylonger to run the GitHub action 'pypa/gh-action-pypi-publish' from a reusable workflow. The code hence needed to be moved upwards, from the reusable workflow _publish_package.yml into the (non-reusable) workflow publish_release.yml
See https://github.com/marketplace/actions/pypi-publish -> Note under "Trusted Publishing"

@ClaasRostock ClaasRostock self-assigned this Nov 14, 2024
@ClaasRostock ClaasRostock linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant