Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for http and path style for filesystem sql_client with s3 #2343

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

adds support for http and path style for filesystem sql_client with s3 #2343

wants to merge 1 commit into from

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Feb 24, 2025

Description

@sh-rp sh-rp linked an issue Feb 24, 2025 that may be closed by this pull request
Minio local endpoint is broken #2303
Open
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit c65e73a
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/67bc6bd303bfb50008d52051
😎 Deploy Preview https://deploy-preview-2343--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

smasyutin
smasyutin approved these changes Feb 28, 2025
View reviewed changes
Copy link

@smasyutin smasyutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with minio via http and s3_url_style=path.

Thank you @sh-rp !

@sh-rp sh-rp marked this pull request as ready for review March 6, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smasyutin smasyutin smasyutin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minio local endpoint is broken
2 participants
@sh-rp @smasyutin