Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install streamlit dependency on dlt pipeline show #158

Open
rudolfix opened this issue Feb 27, 2023 · 5 comments
Open

install streamlit dependency on dlt pipeline show #158

rudolfix opened this issue Feb 27, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@rudolfix
Copy link
Collaborator

rudolfix commented Feb 27, 2023

Background
Make it easy for the user to use dlt .. show command by optionally adding required dependencies

Tasks

    • make another extra so you can install streamlit with python-dlt[streamlit]
    • when running a dlt command, handle MissingImportException and optionally (ask) install the dependencies. Then rerun the command.
    • do not offer installation if dlt is run outside of virtual env. display a warning instead
@TyDunn
Copy link
Collaborator

TyDunn commented Feb 27, 2023

Screenshot 2023-02-27 at 17 23 58

I'm stuck in a loop right now, where it keeps telling me to pip install pandas, even after I have done that

@rudolfix rudolfix added the good first issue Good for newcomers label Feb 28, 2023
@rudolfix
Copy link
Collaborator Author

@TyDunn is it hard for you to switch to python 3.10 and see if this still happens? I can get back to this task end of this week

@TyDunn
Copy link
Collaborator

TyDunn commented Mar 1, 2023

Have the same problem with 3.10.10:
Screenshot 2023-03-01 at 11 17 12

@TyDunn
Copy link
Collaborator

TyDunn commented Mar 1, 2023

Also tried 3.9 and had the same problem too

@rudolfix
Copy link
Collaborator Author

rudolfix commented May 5, 2023

where the problem is coming from:

  1. dlt was pip installed into the main/global python environment
  2. then a virtual environment was created and activated
  3. now the dlt command is run but still from the global environment. it does not see pandas/streamlit so it complains
  4. the user uses pip install but in the activated virtual environment so pandas is installed into it
  5. the dlt ran again in global environment still does not see it so it complains and we are in a loop

How to solve it:

  1. uninstall dlt from global environment, activate virtual environment and install dlt into it

How to fix library:

  1. warn the user when dlt runs from global environment

@rudolfix rudolfix moved this from Todo to Planned in dlt core library Jan 28, 2024
@rudolfix rudolfix moved this from Planned to In Progress in dlt core library Mar 6, 2024
@rudolfix rudolfix moved this from In Progress to Planned in dlt core library Apr 2, 2024
@rudolfix rudolfix moved this from Planned to Todo in dlt core library Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants