Fix/qdrant tests in CI #1526
Merged
Fix/qdrant tests in CI #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
added
the
sprint
steinitzu
commented
Jul 4, 2024
Comment on lines
+39
to
+42
| if config.credentials.is_local(): | ||
| # Local qdrant can not load in parallel | ||
| caps.loader_parallelism_strategy = "sequential" | ||
| caps.max_parallel_load_jobs = 1 |
There was a problem hiding this comment.
workaround for local qdrant, it is not thread safe
There was a problem hiding this comment.
very true! this is why this capability got added :)
steinitzu
commented
Jul 4, 2024
steinitzu
force-pushed
the
fix/qdrant-tests-failing
branch
from
259c866 to
faab3c0
Compare
steinitzu
commented
Jul 4, 2024
Comment on lines
+68
to
+70
| # sync the schema | ||
| p.sync_schema() | ||
| # check if schema exists |
There was a problem hiding this comment.
Local qdrant uses flock and can't handle more than one instance of client, why I moved all the pipeline operations out of with destination_client() scope
rudolfix
previously approved these changes
Jul 4, 2024
Comment on lines
+39
to
+42
| if config.credentials.is_local(): | ||
| # Local qdrant can not load in parallel | ||
| caps.loader_parallelism_strategy = "sequential" | ||
| caps.max_parallel_load_jobs = 1 |
There was a problem hiding this comment.
very true! this is why this capability got added :)
| @@ -63,6 +63,28 @@ class StorageSchemaInfo(NamedTuple): | |||
| inserted_at: datetime.datetime | |||
| schema: str | |||
|
|
|||
| @classmethod | |||
| def from_normalized_mapping( | |||
I just added two destination configs so they both run together. (see |
rudolfix
force-pushed
the
fix/qdrant-tests-failing
branch
from
50e6519 to
a011523
Compare
rudolfix
removed
the
sprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Additional Context