calculate_enrichment bad attrib

[dizak]

7ad31e7

Description

Cannot run stats.calculate_enrichment function.

Steps to reproduce

Pass two dataframes to stats.calculate_enrichment as described by the function __doc__

Expected behavior

stats.calculate_enrichment should return dataframe with enrichment scores.

Actual behavior

stats.calculate_enrichment gives
AttributeError: ("type object 'Columns' has no attribute '_score'", 'occurred at index 0')

[dizak]

This is probably caused by stats.calculate_enrichment was not updated after the SCORE attrib was moved to dtypes in the Columns class.

stats.calculate_enrichment still reference directly to Columns:

selected_bins[Columns.SCORE] = selected_bins.apply(lambda x: Columns._score(x[Columns.COUNT],
                                                                          len(selected),
                                                                          x[Columns.P]),
                                                    axis=1)

[dizak]

This is not true. It cries about score attribute which is logical since this is module-level function. Even the slightly broken indentation seems like there was an accidental autocompletion.

It should probably be:

selected_bins[Columns.SCORE] = selected_bins.apply(lambda x: _score(x[Columns.COUNT],
                                                                        len(selected),
                                                                        x[Columns.P]),
                                                       axis=1)

[szymon-kaczanowski]

Very nice