Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the capacity to create categorical or opaque (length-only) histograms through the react ui #438

Open
jbr opened this issue Aug 23, 2023 · 3 comments

Comments

@jbr
Copy link
Contributor

jbr commented Aug 23, 2023

refs #410, in that new dap allows for additional histogram types
this should only be possible if both aggregators are dap-05+, otherwise the current interface is unchanged

@jbr jbr added the React App label Aug 23, 2023
@divergentdave
Copy link
Collaborator

I created a task with divviup-api 0.0.22, and the task creation form had a field labeled "Selects the number of histogram buckets or counters". The client configuration snippet on the resulting task details pages includes "buckets": [8]. Playing around with the field again, I see it accepts (and reformats) comma-separated lists. I think this just means the copy is a bit ahead of the changes to be implemented in this issue for the time being.

@jbr
Copy link
Contributor Author

jbr commented Aug 31, 2023

Yeah that’s been out of date for a bit; I’m not entirely sure when that copy change happened but we don’t support anything other than continuous integer named buckets currently

@tgeoghegan
Copy link
Contributor

Currently it's possible to create opaque histograms via the API or CLI, but then if you try to examine such a task in the console, you get some JS exceptions. For example: https://app.staging.divviup.org/accounts/9ff34ecb-0091-48bd-ad6e-ab4d234e0669/tasks/4oEbGyWs9r_K8jDckauhPxf3gKbJM5r8907wfw-vJbg

The task at that URL's parameters:

{
    "id": "AJ_Y89nIjAygeNg8jtR9pUypxLd3e-p0HeIpKXMBJGw",
    "account_id": "9ff34ecb-0091-48bd-ad6e-ab4d234e0669",
    "name": "Integration test task 09d678ae-64a2-4916-a483-0ce27c92c05f",
    "vdaf": {
      "type": "histogram",
      "length": 4,
      "chunk_length": 2
    },
    "min_batch_size": 100,
    "max_batch_size": null,
    "created_at": "2023-12-20T00:22:16.477016Z",
    "updated_at": "2023-12-20T00:22:16.477017Z",
    "time_precision_seconds": 28800,
    "report_count": 0,
    "aggregate_collection_count": 0,
    "expiration": "2024-12-19T00:22:16.287115Z",
    "leader_aggregator_id": "a9d48411-0ac6-41d1-904f-9a2def4605ac",
    "helper_aggregator_id": "279f08ad-40ca-4eb7-9fd5-64d0d4ce92ab",
    "collector_credential_id": "f4330d3d-264a-4428-83d4-a39f5995fdd0"
  }

When this feature is implemented, we should make sure that this incorrect behavior is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants