feat: created sponsor DA section on tech pg #289
Conversation
jtfairbank
force-pushed
the
feat/267/sponser-section-tech-pg
branch
from
a968dfb to
593d345
Compare
There was a problem hiding this comment.
@littilemike11 looks great! Answered your question about the color hex codes, and have 1 blocking sugggestion to get that button working. Should be quick to get this one sorted and merged!
src/app/tech/page.tsx
Outdated
| gap={{ initial: "4", lg: "6", xl: "9" }} | ||
| > | ||
| <Box | ||
| <> |
There was a problem hiding this comment.
nitpick: Don't think we need an empty wrapping element, because the wraps everything else?
| return ( | ||
| <Container size={{ xs: "1", sm: "2", md: "3", lg: "4" }} align="center"> | ||
| <Flex width="100%" direction="column" align="center" justify="center"> | ||
| {/* is there a global title color/theme rather than hard coding it in? */} |
There was a problem hiding this comment.
answer: You can tackle this in 2 ways:
- Radix gives us CSS variables defined in the
/src/stylesheets/folder, which you can reference in hard coded styles. Example - Tailwind gives us the color as a class, with custom colors defined in
/tailwind.config.ts. The class names use theirtext-[color]-[weight]&bg-[color]-[weight]conventions. Example:bg-navy-900.
Double check the stylesheets and tailwind config to figure out what specific hex code colors are called. Want to change up the hard coded value here?
| </Strong>{" "} | ||
| </Text> | ||
|
|
||
| <Button size="4" className=" w-max font-normal cursor-pointer"> |
There was a problem hiding this comment.
suggestion (blocking): This button should link to the [email protected] email. You can see an example of buttons doing that on the page's Hero Section component.
…utton, updated stylesheet
What changed?
created sponsor DA section component for tech pg. Added img to tech images.
#267
How will this change be visible?
Changes can be viewed on tech pg and tech components
How can you test this change?
see if new section component closely resembles figma design across various screen sizes