You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have maxArity set to 1024 (the default). This is true for both simpleRestJson clients and servers.
The limit arguably doesn't make as much sense on the client as on the server, because we (hopefully) know whom we're calling, and trust that they're not going to DDOS us - so the default limit should be removed.
I'm not sure how easy it'll be without changing the current APIs, because it'd have to be applied to clients only, and currently the config is shared:
Currently, we have
maxArity
set to 1024 (the default). This is true for bothsimpleRestJson
clients and servers.The limit arguably doesn't make as much sense on the client as on the server, because we (hopefully) know whom we're calling, and trust that they're not going to DDOS us - so the default limit should be removed.
I'm not sure how easy it'll be without changing the current APIs, because it'd have to be applied to clients only, and currently the config is shared:
smithy4s/modules/http4s/src/smithy4s/http4s/SimpleRestJsonBuilder.scala
Lines 57 to 62 in 9a12e32
The behavior should be:
SimpleRestJsonBuilder.client(...).build
- usesInt.MaxValue
SimpleRestJsonBuilder.withMaxArity(1024).client(...).build
- uses1024
(current behavior)SimpleRestJsonBuilder.routes(...).build
- uses1024
The text was updated successfully, but these errors were encountered: