New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic: add more smithy-model utils #1632

Open

kubukoz opened this issue Dec 26, 2024 · 1 comment

Member

kubukoz commented Dec 26, 2024

In smithy4s-dynamic, jvm-only sources, we already have e.g. NodeToDocument. I would also add:

DocumentToNode
conversions between smithy4s ShapeId and smithy-model ShapeId
more?

The text was updated successfully, but these errors were encountered:

Member Author

kubukoz commented Dec 30, 2024

just learned that we already have some of these as internals:

smithy4s/modules/dynamic/src-jvm/internals/conversion/syntax.scala

Line 30 in b25cefe

implicit class ShapeIdOps(sid: ShapeId) {

documentToNode
ShapeId toSmithy

I think they could be moved and exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment