Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent SKU documentation #6468

Closed
MahdiBM opened this issue Oct 1, 2023 · 2 comments
Closed

Inconsistent SKU documentation #6468

MahdiBM opened this issue Oct 1, 2023 · 2 comments

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Oct 1, 2023

Description

The flags field is mentioned in a bunch of places in the SKU documentation but it's not documented.
Furthermore, the json includes a bunch more info that aren't present in the object structure documentation.

Can anyone confirm what is the situation here?
I was trying to update DiscordBM but don't want to add those fields in the json since they are probably not considered documented and would cause (solvable) sem-ver issues in the lib if they are removed.

Screenshot 2023-10-01 at 1 09 08 PM

Steps to Reproduce

N/A

Expected Behavior

The json and the structure should match, and there should be no mention of an undocumented field in the docs.

Current Behavior

The json and the structure do not match, and there is mentions of an undocumented field in the docs.

Screenshots/Videos

No response

Client and System Information

N/A

@colinloretz
Copy link
Contributor

Thanks @MahdiBM, I'll be taking another pass at this today and flags will be included, update to come.

@colinloretz
Copy link
Contributor

Updated in #6477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants