-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
you should replace all the if [ "${CT_*}" = "n" ] by if [ ! "${CT_*}" = "y" ] #14
Comments
Addition: Btw I know you don't want to support ln -s but anyway to support it you should do instead
|
Good point with ! CT_MULTILIB = y, but I don't understand why you added a check before ln -sf? If it already exists then you must have started a build in an existing build folder, which would be a bad thing to do. |
this one not really required but this was when I was testing the non sysroot option, ${CT_PREFIX_DIR}/${CT_TARGET} = CT_SYSROOT_DIR and it was causing en error attempting to create the same link twice so I added this as a safe check But instead I prefer to use a sysroot = prefix so I put everything in top levels so I changed the path a bit more now, I just have one level of subfolders and on windows target, mingw is a link to the tuple dir , on linux /usr also links to the tuple dir and everything in the tuple dir link back to root include lib folder
This would be awesome you support custom sysroot directories |
btw I haven't scanned much = "n" but I haven't looked at case for example, maybe there are so case you look for a "n" |
We don't want to extend the scope of this project too much (which is cross compilation on the 3 biggest desktop OSes targeting those same OSes + iPhone). We already have a very hard time worrying about merging back to upstream! I suggest if you have changes that are not specifically related to the scope of this project then you should submit them to the crossgcc mailing list. |
libc/glibc: install obsolete RPC for both eglibc and glibc
Better replace because for example when you do
if [ "${CT_MULTILIB}" = "n" ]; then
and in the config file
CT_MULTILIB is not set
CT_MULTILIB is indeed to n but the condition will not be executed
It's an example of what I mean conflict when using your build.sh patch because by supporting multilib, you break the no multilib or ln -s support
The text was updated successfully, but these errors were encountered: