Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic text support #12

Closed
annapogorelova opened this issue Mar 13, 2018 · 4 comments
Closed

Cyrillic text support #12

annapogorelova opened this issue Mar 13, 2018 · 4 comments

Comments

@annapogorelova
Copy link
Contributor

Hi @dijs and thank you very much for the great work!

I have tried parsing the wikitext of the article in Cyrillic language (Ukrainian) and looks like the lib doesn't support the Cyrillic text.

var infoboxParser = require("infobox-parser");
var result = infoboxParser(`{{Вулиця України
|назва = Вулиця Підвальна
|населений пункт = Львів
}}`)

Currently this code results in an empty object.

Do you plan to add a support for the Cyrillic text?

@dijs
Copy link
Owner

dijs commented Mar 16, 2018

Ooo, I would love to. But I may need some help with that...

Could you find a simple article we could test parsing with?

And maybe provide a english version as well?

@annapogorelova
Copy link
Contributor Author

annapogorelova commented Mar 16, 2018

Sure. See the links below (a short Wikipedia article about Orion Nebula in English, Ukrainian and Russian):

English
Ukrainian
Russian

@dijs
Copy link
Owner

dijs commented Mar 16, 2018

Interesting... So, I just added tests around this article. And it seems to work just fine. You can see here:

#13

@annapogorelova
Copy link
Contributor Author

Yes, you are right, it works. Maybe I missed something previously, sorry. Anyway, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants