You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
looking at the code, there's a lot of shared behaviour between the UstarHeader and GnuHeader types. There's also quite a lot of casting between the tops (which i guess is fine, since they're just representations of a vector of bytes anyway).
I wonder if the shared behaviour between these objects might be better represented as an Enum or as a trait, rather than being duplicated. Do you have any thoughts on that?
The text was updated successfully, but these errors were encountered:
looking at the code, there's a lot of shared behaviour between the
UstarHeader
andGnuHeader
types. There's also quite a lot of casting between the tops (which i guess is fine, since they're just representations of a vector of bytes anyway).I wonder if the shared behaviour between these objects might be better represented as an
Enum
or as a trait, rather than being duplicated. Do you have any thoughts on that?The text was updated successfully, but these errors were encountered: