Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared 'Header' behaviour #14

Open
danieleades opened this issue Jul 6, 2021 · 1 comment
Open

shared 'Header' behaviour #14

danieleades opened this issue Jul 6, 2021 · 1 comment

Comments

@danieleades
Copy link
Contributor

looking at the code, there's a lot of shared behaviour between the UstarHeader and GnuHeader types. There's also quite a lot of casting between the tops (which i guess is fine, since they're just representations of a vector of bytes anyway).

I wonder if the shared behaviour between these objects might be better represented as an Enum or as a trait, rather than being duplicated. Do you have any thoughts on that?

@dignifiedquire
Copy link
Owner

This part was ported dirctly from the sync implementation, I wouldn't mind a cleanup of that code at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants