From 14e9b55e2fd058a924f5ec9a42d89d4f51f31669 Mon Sep 17 00:00:00 2001 From: Tom Lau <thomasjlau36@gmail.com> Date: Thu, 28 Sep 2023 15:25:55 -0600 Subject: [PATCH 1/2] fixed issues with issuer name --- components/CredentialCard/CredentialCard.module.css | 1 + components/CredentialCard/CredentialCard.tsx | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/components/CredentialCard/CredentialCard.module.css b/components/CredentialCard/CredentialCard.module.css index 95776f6..c41cce6 100644 --- a/components/CredentialCard/CredentialCard.module.css +++ b/components/CredentialCard/CredentialCard.module.css @@ -42,6 +42,7 @@ .secondaryColumn { border-right: 1px solid var(--background); padding: 24px 16px; + padding-bottom: 0; display: flex; flex-direction: column; justify-content: space-between; diff --git a/components/CredentialCard/CredentialCard.tsx b/components/CredentialCard/CredentialCard.tsx index 946fa71..e386d5d 100644 --- a/components/CredentialCard/CredentialCard.tsx +++ b/components/CredentialCard/CredentialCard.tsx @@ -1,4 +1,4 @@ -import { DateTime } from 'luxon'; +import { DateTime, Info } from 'luxon'; import { CompletionDocumentSection } from 'components/CompletionDocumentSection/CompletionDocumentSection'; import { Issuer } from 'components/Issuer/Issuer'; import { IssuerObject, VerifiableCredential } from 'types/credential'; @@ -83,7 +83,11 @@ export const CredentialCard = ({ credential, wasMulti = false }: CredentialCardP </div> <div className={styles.primaryColumn}> - <p className={styles.subjectName}>Subject Name: {displayValues.issuedTo}</p> + {displayValues.issuedTo ? + <InfoBlock header="Issued To:" contents={displayValues.issuedTo} /> + : + null + } <div className={styles.credentialDescription}>{displayValues.credentialDescription}</div> {displayValues.criteria && ( <div> From 549f0fbd5d13fae4af03af11c3f4891c56ea2dfa Mon Sep 17 00:00:00 2001 From: Tom Lau <thomasjlau36@gmail.com> Date: Mon, 2 Oct 2023 15:19:26 -0600 Subject: [PATCH 2/2] added descripton field back --- components/CredentialCard/CredentialCard.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/components/CredentialCard/CredentialCard.tsx b/components/CredentialCard/CredentialCard.tsx index e386d5d..1455740 100644 --- a/components/CredentialCard/CredentialCard.tsx +++ b/components/CredentialCard/CredentialCard.tsx @@ -84,11 +84,15 @@ export const CredentialCard = ({ credential, wasMulti = false }: CredentialCardP <div className={styles.primaryColumn}> {displayValues.issuedTo ? - <InfoBlock header="Issued To:" contents={displayValues.issuedTo} /> + <InfoBlock header="Issued To" contents={displayValues.issuedTo} /> : null } - <div className={styles.credentialDescription}>{displayValues.credentialDescription}</div> + {displayValues.credentialDescription ? + <InfoBlock header="Description" contents={displayValues.credentialDescription}/> + : + null + } {displayValues.criteria && ( <div> <h3 className={styles.smallHeader}>Criteria</h3>