Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revocation status not checked if expired #28

Open
jchartrand opened this issue Jan 14, 2025 · 1 comment · May be fixed by #29
Open

revocation status not checked if expired #28

jchartrand opened this issue Jan 14, 2025 · 1 comment · May be fixed by #29
Assignees

Comments

@jchartrand
Copy link

If a credential is expired, that throws an error here:

vc/lib/index.js

Line 359 in 5eeabad

_checkCredential({credential, log, now});

which isn't caught before the next few lines - which check status - can run.

So status doesn't get checked, but should. Otherwise the verifier UI can only show no status or status false, both of which are wrong and misleadingly.

I think we need to move the status check before the expiry check (i.e, before the _checkCredential call.

This should be done as part of digitalcredentials/verifier-core#3

@jchartrand jchartrand self-assigned this Jan 14, 2025
@jchartrand jchartrand linked a pull request Jan 16, 2025 that will close this issue
@jchartrand jchartrand moved this to In Progress in DCC Engineering Jan 17, 2025
@alexfigtree
Copy link
Member

Possibly fixed by verifier core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants