Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility between LCW and older admin dashboard versions #69

Closed
alexfigtree opened this issue Oct 10, 2024 · 7 comments
Closed
Assignees
Labels
bug Something isn't working priority

Comments

@alexfigtree
Copy link
Member

No description provided.

@alexfigtree alexfigtree converted this from a draft issue Oct 10, 2024
@alexfigtree alexfigtree added bug Something isn't working priority labels Oct 10, 2024
@jchartrand
Copy link
Contributor

jchartrand commented Oct 10, 2024

I've been working today on some problems with the JFF deployment of the admin dashboard, and have fixed two problems:
their admin dashboard was issuing credentials with a non-uri credential id. I've created a new version of the dashboard that remains issuing VC1 only, but fixes the credential.id problem: https://hub.docker.com/layers/digitalcredentials/dashboard/0.1.2/images/sha256-ef610[…]d39f401f43fe1881b5e3c47229a4231edd86e8d04b8e7?context=explore

I created this from a pre-VC2 commit of the dashboard so that JFF wouldn't have to upgrade completely to VC2, which might have messed up their bistring status list, which used the github implementation.

@jchartrand
Copy link
Contributor

Also discovered that the new jsonLD libs in the wallet are likely stricter and didn't like a uri for the issuer.image.id that had a space in it. Replacing the space with the escape code fixes that problem.

@jchartrand
Copy link
Contributor

So after those two fixes, the JFF issuer is now issuing credentials that I can copy/paste into the latest LCW where they are accepted and verify properly.

The problem now, however, is that when trying to add the JFF issued credentials to the latest LCW directly using the deeplink, the transaction service (workflow coordinator) returns a 500. My suspicion is that the request from the LCW to the transaction manager includes a didAuth that has been created and signed using the latest VC libs, but the older version of the dashboard on JFF uses older libs that may be balking for some reason at the newer didAuth.

Investigating...

@jchartrand
Copy link
Contributor

This is the didAuth posted from credentialRequest.ts in the LCW:

{
  "@context": [
    "https://www.w3.org/ns/credentials/v2",
    "https://w3id.org/security/suites/ed25519-2020/v1"
  ],
  "type": [
    "VerifiablePresentation"
  ],
  "holder": "did:key:z6MknevGC6sQwic5wSgZJ49uoyrK6oK4EuqEtFLHbqzh9tch",
  "proof": {
    "type": "Ed25519Signature2020",
    "created": "2024-10-10T17:24:41Z",
    "verificationMethod": "did:key:z6MknevGC6sQwic5wSgZJ49uoyrK6oK4EuqEtFLHbqzh9tch#z6MknevGC6sQwic5wSgZJ49uoyrK6oK4EuqEtFLHbqzh9tch",
    "proofPurpose": "authentication",
    "challenge": "969d28e4-4f9b-4ac6-842d-af023477dbb3",
    "proofValue": "z2w5DT7DVqYTuVop2jjP1psBHd2AVBW66YhfmXr8rFm3QskbUSNCzxA6WRg91gyB6uNLbuERMgGe7otYHEYCErbMf"
  }
}

@jchartrand
Copy link
Contributor

So best guess is that the older VC libraries (version 1) in the JFF installation can't deal with the newer VerifiablePresentation (version 2) that the LCW is posting to the workflow coordinator's endpoint.

@jchartrand
Copy link
Contributor

Confirmed that the LCW is now using VC2 for its didAuth VPs. And so any issuer that wants to issue credentials using the deeplink will have to upgrade to the latest transaction-service. JFF upgraded to the latest transaction-service and it worked.

@alexfigtree alexfigtree moved this from In Progress to Done (Deployed) in DCC Engineering Oct 17, 2024
@alexfigtree
Copy link
Member Author

We can close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
Status: Done (Deployed)
Development

No branches or pull requests

2 participants