Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing null check on get-credential-links auth header crashes server #38

Closed
jchartrand opened this issue Mar 19, 2024 · 2 comments
Closed

missing null check on get-credential-links auth header crashes server #38

jchartrand opened this issue Mar 19, 2024 · 2 comments
Assignees
@jchartrand
Labels
bug Something isn't working

Comments

@jchartrand
Copy link
Contributor

Describe the bug
Missing null check on get-credential-links auth header crashes server. This is the line:

https://github.com/digitalcredentials/admin-dashboard/blob/1b26c63ad42bdd2598c79e6fabbcb8f8506f02db/src/endpoints/getCredentialLinks.ts#L18

To Reproduce

  1. issue a GET request to get-credential-links without an auth header
  2. Server crashes

Expected behavior

Should check that auth header exists before invoking 'startsWith' and should also move the check into the try/catch
@jchartrand jchartrand self-assigned this Mar 19, 2024
@jchartrand jchartrand mentioned this issue Mar 19, 2024
Merged
@jchartrand
Copy link
Contributor Author

jchartrand commented Mar 19, 2024 •
edited
Loading

See PR #39

@jchartrand jchartrand moved this to In Progress in DCC Engineering Mar 20, 2024
@alexfigtree alexfigtree added the bug Something isn't working label Mar 22, 2024
@alexfigtree alexfigtree moved this from In Progress to Release Ready in DCC Engineering Mar 25, 2024
@alexfigtree alexfigtree moved this from Release Ready to Done (Deployed) in DCC Engineering Mar 25, 2024
@alexfigtree
Copy link
Member

Recently deployed, closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchartrand jchartrand

Labels
bug Something isn't working
Projects
DCC Engineering
Status: Done (Deployed)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jchartrand @alexfigtree