Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] Asset: Add tests for InvalidSignature #370

Open
3 tasks
vatsa287 opened this issue Mar 12, 2024 · 7 comments · May be fixed by #402
Open
3 tasks

[C4GT] Asset: Add tests for InvalidSignature #370

vatsa287 opened this issue Mar 12, 2024 · 7 comments · May be fixed by #402
Assignees
@rohansen856
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-asset after adding it in the code.

Goals

  • Add tests for InvalidSignature for pallet/asset

Expected Outcome

  • Test should assert for InvalidSignature being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method asset_create_should_succeed which validates creation of asset.

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts @vatsa287

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]
Aloneking789 added a commit to Aloneking789/cord that referenced this issue Mar 25, 2024
@Aloneking789
tests.rs
f07112b 
FIXES dhiway#370
We're creating a new test function asset_create_should_fail_invalid_signature.
We're setting up the necessary variables such as creator, author, capacity, etc.
We generate an invalid_signature that will intentionally trigger the InvalidSignature error.
@Aloneking789 Aloneking789 linked a pull request Mar 25, 2024 that will close this issue
Open
@Aloneking789
Copy link

I have made a pull request Please merge it

@vatsa287
Copy link
Member Author

@Aloneking789 Welcome! I see multiple PRs being raised without being an assignee.
It would be really appreciated if you could go through #396.
Apart from this PR, I would be closing other PRs for the reasons mentioned in the above discussion.

This was referenced Mar 25, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@Durgesh4993 Durgesh4993 mentioned this issue Apr 6, 2024
Open
@trishanu-init
Copy link

@vatsa287 Please assign this issue to me.

@VedantKhairnar
Copy link

Hello @trishanu-init
Do you need any assistance with the issue or any progress you might want to share?
Thanks.

@rohansen856
Copy link

rohansen856 commented Nov 6, 2024 •
edited
Loading

Hello @vatsa287 @VedantKhairnar i see that this issue has no activity for quite a while. If it's alright, i would like to work on this issue. in that case please assign me this issue.

@vatsa287 vatsa287 assigned rohansen856 and unassigned trishanu-init Nov 7, 2024
@rohansen856 rohansen856 mentioned this issue Nov 7, 2024
Open
@rohansen856
Copy link

@vatsa287, I have solved this issue and raised a PR. Thank you.

@HasanZaigam
Copy link

Hi @vatsa287, this issue is currently active. If it is open, please assign me to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohansen856 rohansen856

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests.rs Aloneking789/cord
7 participants
@atreyasuraj @VedantKhairnar @vatsa287 @trishanu-init @rohansen856 @Aloneking789 @HasanZaigam