-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmptyReply / 404 for JSON not detected as a change. No notification was sent even though the Treat empty page as a change
settings was enabled.
#2528
Comments
According to CURL, their connection is dropping
so hmm not sure what can be done here, its basically like someone hanging up the phone, right? |
https://rdap.verisign.com/net/v1/domain/google.net should work fine tho? |
The first URL is working as intended. Let me try to explain. This is a RDAP server. They show the whois info for a domain. When the domain gets deleted, the whois information is dropped and it shows a 404 error. That means the domain is available. This is what I want to detect. When the URL comes as blank and a 404 error comes up, Change Detection shows the error in the URL list but it doesn't send any notification. I enabled the settings shown on the screenshot which should ignore status error and/or detect empty pages but it still doesn't work. The second URL is completely irrelevant but I included it so you could see what information is shown when a domain still exists. |
The first URL is working as intended. Let me try to explain. This is a RDAP server. They show the whois info for a domain. When the domain gets deleted, the whois information is dropped and it shows a 404 error. This is what I want to detect. It's so close because when the URL comes as blank and a 404 error comes up, Change Detection shows the error in the URL list as you can see above but it doesn't send any notifications. I enabled the settings shown on the screenshot which should ignore status error and/or detect empty pages but it still doesn't work. The second URL is completely irrelevant but I included it so you could see what information is shown when a domain still exists. tl;dr |
Sorry about the close/open. I'm typing through my phone now and my fat fingers tapped on the wrong place. |
Yes, you can see it enabled in the screenshot above. Try it on your end. Add that first URL and enable those options. The error will show up and no notification. |
treat empty page as a change
required settings were enabled.
treat empty page as a change
required settings were enabled.treat empty page as a change
settings was enabled.
Ok so it works if the HTML->Text conversion is empty, for example if the HTML contains this
but not yet if the response content has zero bytes/content |
… the same as when the HTML doesnt render any useful text
ok yeah so not quite a bug, more a misunderstanding/extra feature/not-a-bug-a-feature :) |
treat empty page as a change
settings was enabled.Treat empty page as a change
settings was enabled.
try the |
Good morning. I pulled the :dev container as you said and now I'm getting a different error message.
To get this error message you have to use the same URL that I provided before:
Also, on Filters & Triggers add this to CSS/JSONPath/JQ/XPath Filters:
Still not getting notifications when going from an existing JSON to a blank JSON. Here is a screenshot of the error: |
ok hmm i think you've reached some side-case that cant be fixed, happy if you want to make a PR that includes a test tho - thank you |
yeah looking into it, it really should have an extra option like "Skip filters on empty content" because there's a lot people out there who actually want to know when that filter fails, that would be the main default behaviour i think |
I'm sorry but I don't understand what you mean. What's a PR? Also, instead of trying to workaround the error, would it be possible to an option like "Send notification on watched URL error"? For example, if you are checking a URL and suddenly that URL has an error for any reason (e.g. filter error, 404, file not found, unauthorized, etc), that a notification gets sent when an error shows up. I think that should be possible. Here's an idea that I just tried: I added http://127.0.0.1:5000 to the URL watch list and then I added |
yeah hmm unsure sorry :( you're really running on an edge-case here |
Oh I see. A PR is a pull request. |
Do you think that sending a notification when any error has occurred would not be useful? |
This other issue from last year is basically suggesting the same thing. Back then you agreed. |
You mean like this? #1945 to send a notification on any error ? |
Oh! That's a good one. I'll check if I can help in any way. |
Here's an empty / 404 JSON URL that you can test it with. This one gives out the 404 error and doesn't trigger any notification even with the required settings enabled:
https://rdap.verisign.com/net/v1/domain/emptyjsonurl.net
Here's a working JSON URL that you can test it with, in case you need a working one:
https://rdap.verisign.com/net/v1/domain/google.net
I was watching a JSON that had data and then went blank (404).
I was supposed to get a notification but I didn't get any notification even though all the settings shown in the picture below were enabled.
As you can see in the picture, the status literally shows the error "EmptyReply - try increasing 'Wait seconds before extracting text', Status Code 404" on the URL watch list but a notification was not sent.
Notifications are configured properly. They work on everything else.
I'm using the latest version (0.46.02) on Debian 12.6.
I also tested the previous release (0.46.01) but the same thing happened.
It looks like something similar happened with normal HTMLs on #2501 but the last reply was ignored and the issue was closed.
The text was updated successfully, but these errors were encountered: