AmpCarousel 0.2 "attribute 'version' may not appear" #45

mo-hh234 · 2019-09-25T09:11:06Z

Hey,
when passing version "0.2" to AmpCarousel. I get errors from the AMP Validation Service:

The attribute 'version' may not appear in tag 'AMP-CAROUSEL'.

At the same time im passing version "0.1" to an Amp-Carousel [lighbox]

The attribute 'version' may not appear in tag 'AMP-CAROUSEL lightbox'.

<AmpCarousel version="0.2" ... />

Is there a workaround?

At the same Time i want to use amp-carousel 0.2 but amp-lighbox-gallery 0.1

It seems that this is not possible.

When i set version to 0.2 on the normal AmpCarousel, and 0.1 on the AmpCarousel[lighbox]. The ScriptManager injects

<script async="" custom-element="amp-carousel" src="https://cdn.ampproject.org/v0/amp-carousel-0.1.js"></script>
<script async="" custom-element="amp-lightbox-gallery" src="https://cdn.ampproject.org/v0/amp-lightbox-gallery-0.1.js"></script>

If i set AmpCarousel[lighbox] to 0.2 the correct "amp-carousel" script gets injected. But i get the following AMP Validation Error:

The attribute 'src' in tag 'amp-lightbox-gallery extension .js script' is set to the invalid value 'https://cdn.ampproject.org/v0/amp-lightbox-gallery-0.2.js'.

The text was updated successfully, but these errors were encountered:

dfrankland · 2019-09-26T20:10:23Z

Hmmm, perhaps I we need to update the amphtml-validator-rules and re-run the code generation.

mo-hh234 · 2019-10-02T08:10:08Z

Rerun Code Gerneration does not work.

My workaround is

export default class MyDocument extends Document {
  static async getInitialProps(
    ctx: DocumentContext
  ): Promise<AmpReactDocumentInitialProps> {
    const ampScripts = new AmpScripts();
    const page = await ctx.renderPage(App => props =>
        <AmpScriptsManager ampScripts={ampScripts}>
          <App {...props} />
        </AmpScriptsManager>
    );
    ampScripts.getScripts().forEach(({ extension }) => { // Workaround for https://github.com/dfrankland/react-amphtml/issues/45
      if (extension === "amp-carousel") {
        ampScripts.addExtension({
          extension: "amp-carousel",
          version: "0.2"
        });
      }
      if (extension === "amp-lightbox-gallery") {
        ampScripts.addExtension({
          extension: "amp-lightbox-gallery",
          version: "0.1"
        });
      }
    });
    return {
      ...page,
      ampScriptTags: ampScripts.getScriptElements()
    };
  }

  render() {
    const props = this.props;
    return (
      <Html lang="de">
        <Head>
          {props.ampScriptTags}
        </Head>
        <body>
          <Main />
        </body>
      </Html>
    );
  }
}

I looked into the code and amp-carousel used with lightbox always loads the same version for carousel and lighbox-gallery.

contextHelper({ context, extension: "amp-carousel", version: props.version });

  contextHelper({
    context,
    extension: "amp-lightbox-gallery",
    version: props.version
  });

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AmpCarousel 0.2 "attribute 'version' may not appear" #45

AmpCarousel 0.2 "attribute 'version' may not appear" #45

mo-hh234 commented Sep 25, 2019 •

edited

Loading

dfrankland commented Sep 26, 2019 •

edited

Loading

mo-hh234 commented Oct 2, 2019 •

edited

Loading

AmpCarousel 0.2 "attribute 'version' may not appear" #45

AmpCarousel 0.2 "attribute 'version' may not appear" #45

Comments

mo-hh234 commented Sep 25, 2019 • edited Loading

dfrankland commented Sep 26, 2019 • edited Loading

mo-hh234 commented Oct 2, 2019 • edited Loading

mo-hh234 commented Sep 25, 2019 •

edited

Loading

dfrankland commented Sep 26, 2019 •

edited

Loading

mo-hh234 commented Oct 2, 2019 •

edited

Loading