-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with silex 2 #26
Comments
Yes, it will be upgraded! |
should i write a PR or are you working on it? |
Well, thanks. This is great news. Is there a timeline for silex 2.0 support? |
@simensen any news on this? |
@dominikzogg Thanks for your hard work on this. I pulled down your branch and did some work on it. I had to work in some changes from #25 and #22 that were merged after you started working on this. @cnkt and @dominikzogg: If you can check out ~2.0@dev and make sure it works as you expect it would be super helpful. If everything seems good to go I can aim to create 2.0.0 in the next week. Sound good? |
@dominikzogg: thx, and cool you merged all changes (#22 and #25) too. It seems it work (phpunit test only, got no real app to test) |
@dominikzogg i tested it with a real app, no problems occured. |
@cnkt cool |
@cnkt I cannot make it work with Silex 1.2, did you succeed to fix it ?
Actually, there is still a configuration problem, because Silex 1.2 requires Pimple ~1.0 ; and this provider requires Pimple ~2.1 |
@Flo-Schield-Bobby this one would be for the 1.0 branch: #36 |
Could you mention in the docs that 1.x ist for Silex 1 and 2.x for Silex 2? I just tried "composer install dflydev/dflydev-doctrine-orm-service-provider" but of course it fails now on stable Silex. |
Thank you, @okj579 for the point in the right direction. New to silex / doctrine, and that helped out. |
…ovider#26. We'll see how this goes.
This service provider seems to be not compatible with silex 2 because of requirement of pimple version 1.
Is there a plan to upgrade?
The text was updated successfully, but these errors were encountered: