Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with silex 2 #26

Open
cnkt opened this issue May 31, 2014 · 13 comments
Open

Compatibility with silex 2 #26

cnkt opened this issue May 31, 2014 · 13 comments

Comments

@cnkt
Copy link

cnkt commented May 31, 2014

This service provider seems to be not compatible with silex 2 because of requirement of pimple version 1.

Is there a plan to upgrade?

@simensen
Copy link
Member

Yes, it will be upgraded!

@dominikzogg
Copy link
Contributor

should i write a PR or are you working on it?

@cnkt
Copy link
Author

cnkt commented May 31, 2014

Well, thanks. This is great news. Is there a timeline for silex 2.0 support?

@dominikzogg
Copy link
Contributor

@dominikzogg
Copy link
Contributor

@simensen any news on this?

@simensen
Copy link
Member

@dominikzogg Thanks for your hard work on this. I pulled down your branch and did some work on it. I had to work in some changes from #25 and #22 that were merged after you started working on this.

@cnkt and @dominikzogg: If you can check out ~2.0@dev and make sure it works as you expect it would be super helpful. If everything seems good to go I can aim to create 2.0.0 in the next week. Sound good?

@dominikzogg
Copy link
Contributor

@dominikzogg: thx, and cool you merged all changes (#22 and #25) too. It seems it work (phpunit test only, got no real app to test)

@cnkt
Copy link
Author

cnkt commented Jun 18, 2014

@dominikzogg i tested it with a real app, no problems occured.

@dominikzogg
Copy link
Contributor

@cnkt cool

@flo-sch
Copy link

flo-sch commented Jul 13, 2014

@cnkt I cannot make it work with Silex 1.2, did you succeed to fix it ?
Could you please provide the versions of your composer ?
I currently have :

    "silex/silex": "1.2.*@dev",
    "dflydev/doctrine-orm-service-provider": "~2.0@dev"

Actually, there is still a configuration problem, because Silex 1.2 requires Pimple ~1.0 ; and this provider requires Pimple ~2.1

@dominikzogg
Copy link
Contributor

@Flo-Schield-Bobby this one would be for the 1.0 branch: #36

@okj579
Copy link

okj579 commented Sep 25, 2015

Could you mention in the docs that 1.x ist for Silex 1 and 2.x for Silex 2? I just tried "composer install dflydev/dflydev-doctrine-orm-service-provider" but of course it fails now on stable Silex.

@elightbo
Copy link

Thank you, @okj579 for the point in the right direction. New to silex / doctrine, and that helped out.

elightbo added a commit to elightbo/family-task that referenced this issue Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants