diff --git a/.github/workflows/publish-dfxvm-install-script.yml b/.github/workflows/publish-dfxvm-install-script.yml index 5ab630cdcc..14ca33c04b 100644 --- a/.github/workflows/publish-dfxvm-install-script.yml +++ b/.github/workflows/publish-dfxvm-install-script.yml @@ -4,6 +4,7 @@ on: push: branches: - sdk-1278-dfxvm-install-script + pull_request: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -17,6 +18,7 @@ env: jobs: publish-manifest: + name: dfxvm-install-script-shellcheck runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -37,6 +39,7 @@ jobs: s/ *#.*// " _out/install.sh - name: Upload Artifacts + if: github.event_name == 'push' uses: JamesIves/github-pages-deploy-action@releases/v3 with: single_commit: yes diff --git a/.github/workflows/publish-manifest.yml b/.github/workflows/publish-manifest.yml index a6fa2840e4..da3dea0c11 100644 --- a/.github/workflows/publish-manifest.yml +++ b/.github/workflows/publish-manifest.yml @@ -4,6 +4,7 @@ on: push: branches: - master + pull_request: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -17,6 +18,7 @@ env: jobs: publish-manifest: + name: install-script-shellcheck:required runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 @@ -38,6 +40,7 @@ jobs: " _out/install.sh cp public/manifest.json _out/manifest.json - name: Upload Artifacts + if: github.event_name == 'push' uses: JamesIves/github-pages-deploy-action@releases/v3 with: single_commit: yes diff --git a/src/dfx/.gitignore b/src/dfx/.gitignore deleted file mode 100644 index 8e97362b93..0000000000 --- a/src/dfx/.gitignore +++ /dev/null @@ -1,37 +0,0 @@ -# Created by https://www.gitignore.io/api/rust -# Edit at https://www.gitignore.io/?templates=rust - -### Rust ### -# Generated by Cargo -# will have compiled files and executables -target/ - -# The following is commented out since we need to guarantee all engineers and CI -# are using the same crates. -# # Remove Cargo.lock from gitignore if creating an executable, leave it for libraries -# # More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html -# **/Cargo.lock - -# These are backup files generated by rustfmt -**/*.rs.bk - -# End of https://www.gitignore.io/api/rust - -### ASCIIDOC ### - -/docs/**/*.png -/docs/**/*.svg -!/docs/assets/*.png -!/docs/assets/*.svg -/docs/**/*.html -/docs/**/.asciidoctor - -README.html - -### Working files ### -.* -!.gitignore -!.cargo -,* -*~ -*.bak