Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ping-pong flow in the chat actor using current parser #3

Open
ygunayer opened this issue Nov 2, 2018 · 0 comments
Open

Comments

@ygunayer
Copy link
Member

ygunayer commented Nov 2, 2018

Our chat actor currently parses the incoming TcpStream on its own, but this is sub-optimal. We need to borrow this logic from the current parser, which in turn will be replaced with a separate codec phase when #2 is done.

We still think that the ChatIOActor should keep its role as the supervisor and I/O gateway for the ChatActor itself, so the process of capturing the string from the TcpStream, passing it through the parser, and sending properly parsed commands to the ChatActor should be handled in the ChatIOActor as well.

Likewise, the act of receiving commands or messags from the ChatActor, and converting them to a string through the codec library should be the ChatIOActor's responsibility too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant