Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed previous semester workflow should disgusting between attempts and re-uses #1296

Open
torgeirl opened this issue May 6, 2024 · 0 comments
Milestone

Comments

@torgeirl
Copy link
Collaborator

torgeirl commented May 6, 2024

Using the Passed previous semester wizards, it is a little too easy for a semester administrator to re-use an already re-used result.

For instance, given the following events for a student in a course:

Semester Assignment actions Assignment result
2021 Delivered Passed
2022 - Passed (based on 2021)
2023 - - (not a student that semester)
2024 - Passed (based on both 2021 and 2022)

If then the results from 2021 was deleted before the 2024 semester, the result from running the Passed previous semester wizards would still suggest the assignment should be set as Passed based on the result from 2022 even thought the 2022 result in based on the result of a now deleted assignment:

Semester Assignment actions Assignment result
2022 - Passed (based on the now deleted 2021)
2023 - - (not a student that semester)
2024 - Passed (based on 2022)

This is not the intended result of Passed previous semester, and we should make adjustments so it doesn't re-use results that are themselves re-used.

Suggested solutions

  • when assignments are passed using the Passed previous semester wizards it should be noted what result(s) that are re-used (could default to the most recent result)
  • when running the Passed previous semester wizards, previous results that are marked as re-uses should be ignored
@torgeirl torgeirl added this to the Devilry 6.5 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant