You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the new master, rrboss is broken: n_target should be n_targets.
Why even creating n_targets? We could simply use args.ntargets
n_targets = None
if args.ntargets is not None:
n_targets = args.ntargets
first_target = None
if args.mintarget is not None:
first_target = args.mintarget
elif n_targets is not None:
first_target = 0
if args.ntargets is not None:
targets = targets[first_target:first_target+n_targets]
meta = meta[first_target:first_target+n_targets]
The text was updated successfully, but these errors were encountered:
Thanks for catching this (unfortunately I only tested rrdesi, not rrboss). Please go ahead and fix (but make sure that all combinations work: only --mintarget, only --ntargets, or both --mintarget and --ntargets).
redrock/py/redrock/external/boss.py
Line 314 in d0a3260
In the new master, rrboss is broken:
n_target
should ben_targets
.Why even creating
n_targets
? We could simply useargs.ntargets
The text was updated successfully, but these errors were encountered: