Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_target should be n_targets #74

Closed
londumas opened this issue Jan 19, 2018 · 1 comment
Closed

n_target should be n_targets #74

londumas opened this issue Jan 19, 2018 · 1 comment
Labels

Comments

@londumas
Copy link
Contributor

n_target = args.ntargets

In the new master, rrboss is broken: n_target should be n_targets.
Why even creating n_targets? We could simply use args.ntargets

    n_targets = None
    if args.ntargets is not None:
        n_targets = args.ntargets

    first_target = None
    if args.mintarget is not None:
        first_target = args.mintarget
    elif n_targets is not None:
        first_target = 0
        if args.ntargets is not None:
            targets = targets[first_target:first_target+n_targets]
            meta = meta[first_target:first_target+n_targets]
@londumas londumas added the bug label Jan 19, 2018
@sbailey
Copy link
Collaborator

sbailey commented Jan 19, 2018

Thanks for catching this (unfortunately I only tested rrdesi, not rrboss). Please go ahead and fix (but make sure that all combinations work: only --mintarget, only --ntargets, or both --mintarget and --ntargets).

Related to #70 #71 and #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants