Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

study performance on cosmics-masked coadds #189

Open
sbailey opened this issue Feb 16, 2021 · 0 comments
Open

study performance on cosmics-masked coadds #189

sbailey opened this issue Feb 16, 2021 · 0 comments

Comments

@sbailey
Copy link
Collaborator

sbailey commented Feb 16, 2021

Study the performance of redrock on cosmics-masked coadds. On a low-statistics cross check of ELG tile 80608 on night 20201216, the results weren't convincing that cosmics masking/coadds were helping.

Comparing redrock fits on spectra (without cosmics masking) vs. desi_coadd_spectra --nsig 4 coadds with cosmics masking, 63 differed by more than 300 km/s. However, only 4 of those were in the truth table /global/cfs/cdirs/desi/sv/vi/TruthTables/Blanc/ELG/desi-vi_ELG_tile80608_nightdeep_merged_all_210208.csv with best_quality>2.5. Of those 4:

TARGETID           Z
39633321168212037  1.0433  orig correct, cosmics-masked coadd changed to 0.78, both with ZWARN=4
39633334912946761  1.6321  orig wrong, cosmics-masked coadd correct, both with ZWARN=4
39633338322913292  1.629   both incorrect, but cosmics-masked coadd incorrectly confident ZWARN=0
39633341661577371  2.371   orig correct, cosmics-masked coadd changed to 1.37, both with ZWARN=4

i.e. it's only 4 targets and all of them had ZWARN=4 in the orig spectra, but 3 out of 4 cases the orig non-cosmics masked version was more correct. There might be some confirmation bias in the truth table since it was also vetted on an earlier non-cosmics masked version of these spectra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant