Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate pre-calculated healpix pixel number #238

Closed
sbailey opened this issue Nov 14, 2017 · 2 comments
Closed

propagate pre-calculated healpix pixel number #238

sbailey opened this issue Nov 14, 2017 · 2 comments

Comments

@sbailey
Copy link
Contributor

sbailey commented Nov 14, 2017

Filing under desitarget because this is where it starts, but this is a cross repo ticket. From @weaverba137 in desihub/two_percent_DESI#6:

If healpix ids are known at the time of fiberassignment, it would be good to include those. It would possibly simplify some joins.

Target selection calculates this and outputs as HPXPIXEL column. This should be propagated through fiber assignment, fibermap files, expanded fibermap tables in spectra files, and included in the output zcatalog table.

Currently we recalculate the healpixel ID from RA,dec at multiple steps. This is reproducible as long as we stay within python and healpy, but it could become problematic if we ever branch beyond that and use a different healpix library that may have edge effect differences (AFAICT the healpix standard doesn't define which pixel an (RA,dec) belongs to if it lands exactly on a pixel boundary or corner).

@moustakas
Copy link
Member

I propose we close this issue, since it's not really for desitarget. I created specific issues in
desihub/desisim#410 and
desihub/fiberassign#96 (comment) so we can track this there.

We probably also need an issue in redrock (or desispec?), to ensure the (same) healpixel number gets all the way to the end.

@moustakas
Copy link
Member

I believe the healpix number is being correctly propagated, at least when it leaves desitarget and at through fiberassign. There's still an open issue in desisim (desihub/desisim#410) but we can dispense with that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants