From bc30083935af460ffef614612a86a1ae2f706b31 Mon Sep 17 00:00:00 2001 From: itaihanski Date: Sun, 17 Nov 2024 15:52:36 +0200 Subject: [PATCH] Doc fixes --- .../java/com/descope/android/DescopeFlowCoordinator.kt | 1 - .../src/main/java/com/descope/android/DescopeFlowView.kt | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/descopesdk/src/main/java/com/descope/android/DescopeFlowCoordinator.kt b/descopesdk/src/main/java/com/descope/android/DescopeFlowCoordinator.kt index 9f96676d..567acb38 100644 --- a/descopesdk/src/main/java/com/descope/android/DescopeFlowCoordinator.kt +++ b/descopesdk/src/main/java/com/descope/android/DescopeFlowCoordinator.kt @@ -377,7 +377,6 @@ private fun String.toUri(): Uri? { private fun shouldUseCustomSchemeUrl(context: Context): Boolean { val browserIntent = Intent("android.intent.action.VIEW", Uri.parse("http://")) val resolveInfo = context.packageManager.resolveActivity(browserIntent, PackageManager.MATCH_DEFAULT_ONLY) - println(resolveInfo?.loadLabel(context.packageManager).toString().lowercase()) return when(resolveInfo?.loadLabel(context.packageManager).toString().lowercase()){ "opera", "opera mini", diff --git a/descopesdk/src/main/java/com/descope/android/DescopeFlowView.kt b/descopesdk/src/main/java/com/descope/android/DescopeFlowView.kt index 9d96c500..3a9daf7d 100644 --- a/descopesdk/src/main/java/com/descope/android/DescopeFlowView.kt +++ b/descopesdk/src/main/java/com/descope/android/DescopeFlowView.kt @@ -36,8 +36,8 @@ data class DescopeFlow(val uri: Uri) { /** * An optional deep link link URL to use when performing OAuth authentication, overriding * whatever is configured in the flow or project. - * - **IMPORTANT NOTE**: even the Application links are the recommended way to configure - * deep links, some browsers, such as Opera, do not honor them and open the URLs inline. + * - **IMPORTANT NOTE**: even though App Links are the recommended way to configure + * deep links, some browsers, such as Opera, do not respect them and open the URLs inline. * It is possible to circumvent this issue by providing a custom scheme based URL via [oauthRedirectCustomScheme]. */ var oauthRedirect: String? = null @@ -55,8 +55,8 @@ data class DescopeFlow(val uri: Uri) { /** * An optional deep link link URL to use performing SSO authentication, overriding * whatever is configured in the flow or project - * - **IMPORTANT NOTE**: even the Application links are the recommended way to configure - * deep links, some browsers, such as Opera, do not honor them and open the URLs inline. + * - **IMPORTANT NOTE**: even though App Links are the recommended way to configure + * deep links, some browsers, such as Opera, do not respect them and open the URLs inline. * It is possible to circumvent this issue by providing a custom scheme via [ssoRedirectCustomScheme] */ var ssoRedirect: String? = null