Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Relative links are broken when linking an issue from a monorepo #8864

Open
1 task done
Yash-Singh1 opened this issue Jan 23, 2024 · 0 comments
Open
1 task done
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working

Comments

@Yash-Singh1
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

pnpm

Package manager version

8.14.1

Language version

Node v18

Manifest location and content before the Dependabot update

package.json https://github.com/Yash-Singh1/yashsingh.us/blob/main/package.json
.github/dependabot.yml https://github.com/Yash-Singh1/yashsingh.us/blob/main/.github/dependabot.yml

dependabot.yml content

https://github.com/Yash-Singh1/yashsingh.us/blob/main/.github/dependabot.yml

version: 2
updates:
  - package-ecosystem: npm
    directory: '/'
    schedule:
      interval: daily
      time: '13:00'
    open-pull-requests-limit: 10

  - package-ecosystem: 'github-actions'
    directory: '/'
    schedule:
      interval: 'daily'

Updated dependency

lucide-react from 0.312.0 to 0.314.0

Yash-Singh1/yashsingh.us#129

What you expected to see, versus what you actually saw

Here is the markdown of the PR comment:

Bumps [lucide-react](https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react) from 0.312.0 to 0.314.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/lucide-icons/lucide/releases">lucide-react's releases</a>.</em></p>
<blockquote>
<h2>New icons 0.314.0</h2>
<h2>New icons 🎨</h2>
<ul>
<li><code>ticket-check</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
<li><code>ticket-minus</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
<li><code>ticket-percent</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
<li><code>ticket-plus</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
<li><code>ticket-slash</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
<li><code>ticket-x</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312">#1312</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
</ul>
<h2>New icons 0.313.0</h2>
<h2>New icons 🎨</h2>
<ul>
<li><code>text-search</code> (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1807">#1807</a>) by <a href="https://github.com/danielbayley"><code>@​danielbayley</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/lucide-icons/lucide/commit/55f264bea607a11250e8235cf95396fb54a4869d"><code>55f264b</code></a> Bump vite from 5.0.10 to 5.0.12 (<a href="https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1817">#1817</a>)</li>
<li>See full diff in <a href="https://github.com/lucide-icons/lucide/commits/0.314.0/packages/lucide-react">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=lucide-react&package-manager=npm_and_yarn&previous-version=0.312.0&new-version=0.314.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Note how the links to the issues: https://github.com/lucide-icons/lucide/tree/HEAD/packages/lucide-react/issues/1312 are broken.

Native package manager behavior

I am pretty sure this behavior is not related to the package manager behavior, but more related to something about how the release notes details is generated. I don't know Ruby, but I am guessing it's something related to how release notes are built here?:

build_details_tag(summary: "Release notes", body: msg)

Images of the diff or a link to the PR, issue, or logs

Here is the PR link: Yash-Singh1/yashsingh.us#129

Smallest manifest that reproduces the issue

I don't think this issue requires a smaller reproduction because it is related to how the PR comment is generated regardless of how my repository is formatted, but if you want me to create a smaller reproduction, LMK.

@Yash-Singh1 Yash-Singh1 added the T: bug 🐞 Something isn't working label Jan 23, 2024
@abdulapopoola abdulapopoola added the L: javascript:pnpm npm packages via pnpm label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants