Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the instance of a file-input component in forms-system/src/js/fields/FileField.jsx with the v3 web-component #3870

Open
2 of 6 tasks
humancompanion-usds opened this issue Feb 27, 2025 · 2 comments
Assignees

Comments

@humancompanion-usds
Copy link
Collaborator

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Our component usage report turned up no instances of the v1 File input component in vets-website. However, teams keep turning up in Collab Cycle showing examples of what looks like the v1 instance of file input. That is fact this component forms-system/src/js/fields/FileField.jsx, which is an imposter.

What I expected to happen

I expected that when we had matched the functionality of the v1 file input component that we'd deprecate it in favor of the v3 component. Instead we have potentially 30 different applications all using the same lousy UX of the v1 file input.

Reproducing

You can see this FileField.jsx used in the Benefits Dependent Experience, 21-686c/674 forms and Andrew informs me that there are roughly 30 files which import the fileUploadUI which uses the FileField.jsx forms-system field.

Urgency

This is blocking our deprecation of the v1 file input user experience. While technically speaking the v1 file-input component itself isn't being used, that matters little to the user subjected to the UX, which is deficient in a number of ways.

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

The Design System team should work with the Veteran-facing Forms team to replace the instance in the Forms system. We should first do some discovery to ensure our v3 component supports everything the FileField.jsx file offers. On that note, in future we should make a review of how a component is or is not being used in the Forms system a standard part of our component development procedure.

@micahchiang
Copy link
Contributor

@caw310 @tbaker1026 - we should discuss which team will be taking point on actual dev work here. We can do this when Carol returns to the office.

@tbaker1026
Copy link

@micahchiang I will set up a meeting next week. Nick has some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants